-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #54790
Rollup of 10 pull requests #54790
Conversation
…t declared in their `Cargo.toml`.
If the rust-enabled lldb was built, then use it when running the debuginfo tests. Updating the lldb submodule was necessary as this needed a way to differentiate the rust-enabled lldb, so I added a line to the --version output. This adds compiletest commands to differentiate between the rust-enabled and non-rust-enabled lldb, as is already done for gdb. A new "rust-lldb" header directive is also added, but not used in this patch; I plan to use it in rust-lang#54004. This updates all the tests.
I noticed a small typo while reading over this document.
In rust-lang#51833, I improved the performance of `copy_undef_mask()`. As such, the old FIXME wasn't appropriate anymore. The main remaining thing left to do is to implement a fast path for non-overlapping copies (per @oli-obk).
…ror, r=GuillaumeGomez Add doc for impl From for Std Error As part of issue rust-lang#51430 (cc @skade). I am not sure if it is going to a correct direction so put up here so that people can comment.
Add checking for tool distribution in Tier 1 This fixes rust-lang#54483 r? @kennytm
…idtwco [NFC] `getopts` is used by `librustc` and `librustc_driver`, but isn't declared in their `Cargo.toml`.
Cleanup rustc/ty part 2 The second part of cleanups and minor improvements for rustc/ty. - improve allocations - calculate span after a possible early continue - simplify some patterns - mark a comment as FIXME - whitespace fixes The PR is independent from from the first part.
Make spec_extend use for_each() `for_each` will use an iterator's own implementation of `try_fold`, which I understand to be generally preferable (because nested iterator adapter's will use each other's `try_fold` and be designed for the specific adaptation in a way that promotes performance and inlining.
Run debuginfo tests against rust-enabled lldb, when possible If the rust-enabled lldb was built, then use it when running the debuginfo tests. Updating the lldb submodule was necessary as this needed a way to differentiate the rust-enabled lldb, so I added a line to the --version output. This adds compiletest commands to differentiate between the rust-enabled and non-rust-enabled lldb, as is already done for gdb. A new "rust-lldb" header directive is also added, but not used in this patch; I plan to use it in rust-lang#54004. This updates all the tests.
Fix typo in CONTRIBUTING.md I noticed a small typo while reading over this document.
…i-obk Update a FIXME in memory.rs In rust-lang#51833, I improved the performance of `copy_undef_mask()`. As such, the old FIXME wasn't appropriate anymore. The main remaining thing left to do is to implement a fast path for non-overlapping copies (per @oli-obk). r? @oli-obk
Update clippy None
A handful of cleanups for rustc/mir - use the "regular" `into()` instead of `graphviz::IntoCow` in `mod.rs` - `format!("{}", x)` > `x.to_string()` - remove one unnecessary `String` allocation - shorten the logic of one loop - `assert!(x == y)` > `assert_eq!(x, y)` - whitespace & formatting fixes r? @oli-obk
@bors r+ p=10 |
📌 Commit 94508ca has been approved by |
⌛ Testing commit 94508ca with merge c629af2bff8abd6b2e58e7fdba25a894de207288... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
getopts
is used bylibrustc
andlibrustc_driver
, but isn't declared in theirCargo.toml
. #54698 ([NFC]getopts
is used bylibrustc
andlibrustc_driver
, but isn't declared in theirCargo.toml
.)Failed merges:
r? @ghost